Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/shgu/crlf fix #1521

Merged
merged 3 commits into from
Mar 30, 2018
Merged

Conversation

Shyam-Gupta
Copy link
Member

Repro Steps:

  1. Using vstest.console.exe, user runs a test which has Trace.Writeline() statement with some line breaks, and generates a trx file
  2. Open the trx file in Visual Studio
  3. Select the test result, right click --> View Test Results Details

Result: In the Results window, check the ‘Standard Console Output section’. Notice that the text is present in a single line and not in multiple lines.

Issue: Carriage Return character is not getting retained while generating TRX file

Fix: In TrxLogger, PopulateTrxFile(), while saving the file use XmlWriter and in its settings, specify NewLineHandling.Entitize option

@Shyam-Gupta
Copy link
Member Author

@dotnet-bot retest Windows_NT / Release Build please

@Shyam-Gupta Shyam-Gupta merged commit 3307616 into microsoft:master Mar 30, 2018
@Shyam-Gupta Shyam-Gupta deleted the dev/shgu/crlfFix branch March 30, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants