Filtering sources based on assembly type #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishkk
commented
Apr 9, 2018
| if (discoverer.Metadata.AssemblyType == AssemblyType.Native || | ||
| discoverer.Metadata.AssemblyType == AssemblyType.Managed) | ||
| { | ||
| assemblyTypeToSoucesMap = assemblyTypeToSoucesMap ?? GetAssemblyTypeToSoucesMap(sources); |
abhishkk
requested review from
acesiddhu,
smadala,
cltshivash,
singhsarab and
mayankbansal018
* Correcting Tests
abhishkk
commented
Apr 10, 2018
| @@ -31,6 +34,7 @@ public class DiscovererEnumeratorTests | |||
| private DiscoveryResultCache discoveryResultCache; | |||
| private Mock<IRequestData> mockRequestData; | |||
| private Mock<IMetricsCollection> mockMetricsCollection; | |||
| private Mock<IAssemblyProperties> mockPEReaderHelper; | |||
There was a problem hiding this comment.
renaming mockPEReaderHelper to mockAssemblyProperties
smadala
approved these changes
Apr 10, 2018
| } | ||
|
|
||
| // Added this to make class testable, needed a PEHeader mocked Instance |
There was a problem hiding this comment.
Nit: needed a AssemblyProperties or remove comment.
| var result = new Dictionary<LazyExtension<ITestDiscoverer, ITestDiscovererCapabilities>, IEnumerable<string>>(); | ||
| var sourcesForWhichNoDiscovererIsAvailable = new List<string>(sources); | ||
|
|
||
| foreach (var discoverer in allDiscoverers) | ||
| { | ||
| var sourcesToCheck = sources; | ||
|
|
||
| if (discoverer.Metadata.AssemblyType == AssemblyType.Native || |
There was a problem hiding this comment.
Is there a chance discoverer can support both managed and native?
There was a problem hiding this comment.
No. adapter can't mention both
| assemblyTypeToSoucesMap[assemblyProperties.GetAssemblyType(source)] : | ||
| assemblyTypeToSoucesMap[AssemblyType.None]; | ||
|
|
||
| ((List<string>)sourcesList).Add(source); |
| } | ||
| finally | ||
| { | ||
| this.ResetDiscoverers(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of RFC:
Contains changes for filtering sources based on assembly type.