Always Flush test results,even if RecordEnd is not called #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadala
reviewed
May 4, 2018
| @@ -178,13 +178,9 @@ public void RecordResultShouldFlushIfTestCaseEndWasCalledBefore() | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void RecordResultShouldNotFlushIfTestCaseEndWasNotCalledBefore() | |||
| public void RecordResultShouldFlushEvenIfTestCaseEndWasCalledBefore() | |||
There was a problem hiding this comment.
Rename RecordResultShouldFlushEvenIfTestCaseEndWasNotCalled or remove this test.
| @@ -45,7 +43,6 @@ public TestExecutionRecorder(ITestCaseEventsHandler testCaseEventsHandler, ITest | |||
| // 3. Test Case Result. | |||
| // If that is not that case. | |||
| // If Test Adapters don't send the events in the above order, Test Case Results are cached till the Test Case End event is received. | |||
| @@ -144,32 +119,15 @@ public void RecordEnd(TestCase testCase, TestOutcome outcome) | |||
| lock (this.testCaseEndStatusSyncObject) | |||
| { | |||
| isTestCaseEndAlreadySent = this.testCaseEndStatusMap.Contains(testCase.Id); | |||
There was a problem hiding this comment.
Can we remove testCaseEndStatusMap too?
There was a problem hiding this comment.
Thought about , but wasn't sure so didn't take it up in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestResults are not flushed if datacollection is enabled, & RecordEnd is not invoked.
Related issue
Fixes #1519