Update Test Source with Package for Inprogress Tests #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankbansal018
changed the title
mayankbansal018
changed the title
smadala
reviewed
May 18, 2018
| @@ -376,7 +376,7 @@ function Publish-Package | |||
| Copy-PackageItems "Microsoft.TestPlatform.Build" | |||
|
|
|||
| # Copy IntelliTrace components. | |||
| $intellitraceSourceDirectory = Join-Path $env:TP_PACKAGES_DIR "Microsoft.Internal.Intellitrace\15.5.0-preview-20171207-01\tools" | |||
| $intellitraceSourceDirectory = Join-Path $env:TP_PACKAGES_DIR "Microsoft.Internal.Intellitrace\15.8.0-preview-20180518-04\tools" | |||
| public void RunTestsTestRunCompleteShouldUpdateTestCasesWithPackageIfProvided() | ||
| { | ||
| var package = "x.apprecipe"; | ||
| TestRunCompleteEventArgs receivedRunCompleteArgs = null; |
| { | ||
| Assert.AreEqual(tr.TestCase.Source, package); | ||
| } | ||
| Assert.IsTrue(receivedRunStatusArgs.ActiveTests == null || receivedRunStatusArgs.ActiveTests.Count() == 0); |
There was a problem hiding this comment.
Assert missing for ActiveTests.Source? #Closed
There was a problem hiding this comment.
Assert for source is just 2 line above
| @@ -799,6 +866,18 @@ private class TestableBaseRunTests : BaseRunTests | |||
| { | |||
| } | |||
|
|
|||
| public TestableBaseRunTests( | |||
There was a problem hiding this comment.
Was not sure how it will disturb other test, & doing it now will mean I can't get devdiv PR out today.
mayankbansal018
commented
May 18, 2018
| Assert.AreEqual(tr.TestCase.Source, package); | ||
| } | ||
| Assert.IsTrue(receivedRunStatusArgs.ActiveTests == null || receivedRunStatusArgs.ActiveTests.Count() == 0); | ||
| } |
There was a problem hiding this comment.
Assert for source is just 2 line above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Test Source with Package for InProgress Tests
Related issue
Fixes https://developercommunity.visualstudio.com/content/problem/252751/unit-tests-failing-with-error-testcontainer-was-no.html