Migrate DateTime.Now to DateTime.UtcNow to make sure all test reporti… #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng content like trx contains the right data
smadala
suggested changes
May 22, 2018
| @@ -272,7 +272,7 @@ internal string WriteEventLogs(List<EventLogEntry> eventLogEntries, int maxLogEn | |||
| "{0}-{1}-{2:yyyy}{2:MM}{2:dd}-{2:HH}{2:mm}{2:ss}.{2:fff}", | |||
| "Event Log", | |||
| Environment.MachineName, | |||
| DateTime.Now); | |||
| DateTime.UtcNow); | |||
There was a problem hiding this comment.
Can you add tests for these?
smadala
approved these changes
May 23, 2018
| @@ -1,6 +1,8 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
|
|
|||
| using System.Xml.Linq; | |||
There was a problem hiding this comment.
Nit: This should go under namespace.
| @@ -36,8 +36,8 @@ public TestResult(TestCase testCase) | |||
|
|
|||
| // Default start and end time values for a test result are initialized to current timestamp | |||
| // to maintain compatibility. | |||
| this.StartTime = DateTimeOffset.Now; | |||
| this.EndTime = DateTimeOffset.Now; | |||
| this.StartTime = DateTimeOffset.UtcNow; | |||
There was a problem hiding this comment.
This could change the behavior for inner loop scenarios. If any client displaying time it's client responsibility to localize the date. TestPlatform will use UTC for consistence.
There was a problem hiding this comment.
As we discussed, it might be. But we need to draw this and follow everywhere as UTC standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate DateTime.Now to DateTime.UtcNow to make sure all test reporting content like trx contains the right data
Issues: https://developercommunity.visualstudio.com/content/problem/196633/tfs-2018-failed-to-publish-test-results-the-value.html