Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LUT InProcDataCollector issue #1615

Merged
merged 3 commits into from
May 24, 2018

Conversation

singhsarab
Copy link
Contributor

Fixed RecordResult to SendTestCaseEnd if not already sent for datacollectors to end and get attachments correctly.

WorkItem : https://devdiv.visualstudio.com/DevDiv/_workitems/edit/620855

…lectors to end and get attachments correctly.
@singhsarab singhsarab changed the title Fix for LUT lineInfo Issue Fix for LUT InProcDataCollector issue May 23, 2018
@@ -153,7 +153,7 @@ public void RecordResultShouldPublishTestCaseResultEventIfTestCaseStartAndTestCa
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: RecordEnd.

@@ -178,11 +178,28 @@ public void RecordResultShouldFlushIfTestCaseEndWasCalledBefore()
}

[TestMethod]
public void RecordResultShouldFlushEvenIfTestCaseEndWasCalledBefore()
public void RecordResultShouldFlushIfRecordEndWasNotCalledBefore()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: CalledAfter.

Copy link
Contributor

@mayankbansal018 mayankbansal018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@singhsarab singhsarab merged commit 12f4015 into microsoft:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants