Find ISettingsProvider in TestAdapter assembly #1704

smadala · 2018-07-30T10:45:23Z

Description

Fix Settings Provider named 'GoogleTestAdapterSettings' was not found.
In Tpv1 we don't filter by SettingsProvider.dll More details

<?xml version="1.0" encoding="utf-8"?>
<RunSettings>
  <GoogleTestAdapterSettings>
    <SolutionSettings>
      <Settings>
        <AdditionalTestExecutionParam>-testdirectory=$(TestDir)</AdditionalTestExecutionParam>
        <BatchForTestSetup>$(SolutionDir)Tests\Returns0.bat</BatchForTestSetup>
        <BatchForTestTeardown>$(SolutionDir)Tests\Returns1.bat</BatchForTestTeardown>
        <WorkingDir>$(SolutionDir)</WorkingDir>
      </Settings>
    </SolutionSettings>
    <ProjectSettings>
      <Settings ProjectRegex="LoadTests_gta\.exe|CrashingTests_gta\.exe">
        <TestDiscoveryRegex>.*Tests.*_gta.exe</TestDiscoveryRegex>
      </Settings>
      <Settings ProjectRegex=".*\\Tests_gta\.exe">
        <TestDiscoveryTimeoutInSeconds>60</TestDiscoveryTimeoutInSeconds>
      </Settings>
    </ProjectSettings>
  </GoogleTestAdapterSettings>
</RunSettings>

Related issue

#1652
#1673

mayankbansal018 · 2018-07-30T12:21:15Z

src/Microsoft.TestPlatform.Common/SettingsProvider/SettingsProviderExtensionManager.cs

@@ -115,7 +115,7 @@ public static SettingsProviderExtensionManager Create()

                        TestPluginManager.Instance
                            .GetSpecificTestExtensions<TestSettingsProviderPluginInformation, ISettingsProvider, ISettingsProviderCapabilities, TestSettingsProviderMetadata>(
-                                TestPlatformConstants.SettingsProviderEndsWithPattern,
+                                TestPlatformConstants.TestAdapterEndsWithPattern,


TestAdapterEndsWithPattern [](start = 54, length = 26)

Should we keep SetttingsProvider pattern as well, in case(extreme rare) for folks who might have used this pattern to define their ISettings

Creating separate assembly for just to implement ISettingsProvider don't give better experience for adapter authors.

Can we please add tests for this change if possible ?

mayankbansal018 · 2018-07-30T12:23:29Z

src/Microsoft.TestPlatform.Common/Constants.cs

-        /// <summary>
-        /// Pattern used to find the settings providers library using String.EndWith
-        /// </summary>
-        public const string SettingsProviderEndsWithPattern = @"SettingsProvider.dll";


This will need to remain, if other comment is honored

mayankbansal018 · 2018-07-30T12:23:50Z

src/Microsoft.TestPlatform.Client/TestPlatform.cs

@@ -225,7 +225,7 @@ private void AddExtensionAssemblies(string runSettings)
                        continue;
                    }

-                    var extensionAssemblies = new List<string>(this.fileHelper.EnumerateFiles(adapterPath, SearchOption.AllDirectories, TestPlatformConstants.TestAdapterEndsWithPattern, TestPlatformConstants.TestLoggerEndsWithPattern, TestPlatformConstants.RunTimeEndsWithPattern, TestPlatformConstants.SettingsProviderEndsWithPattern));
+                    var extensionAssemblies = new List<string>(this.fileHelper.EnumerateFiles(adapterPath, SearchOption.AllDirectories, TestPlatformConstants.TestAdapterEndsWithPattern, TestPlatformConstants.TestLoggerEndsWithPattern, TestPlatformConstants.RunTimeEndsWithPattern));


This will also need to remain

Find ISettingsProvider in TestAdapter assembly

8bbf6dc

smadala requested review from mayankbansal018 and singhsarab July 30, 2018 12:07

mayankbansal018 reviewed Jul 30, 2018

View reviewed changes

singhsarab approved these changes Jul 30, 2018

View reviewed changes

smadala merged commit aad2f43 into microsoft:master Jul 30, 2018

smadala deleted the fix-isettings-provider-02 branch July 30, 2018 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Find ISettingsProvider in TestAdapter assembly #1704

Find ISettingsProvider in TestAdapter assembly #1704

smadala commented Jul 30, 2018 •

edited

Loading

mayankbansal018 Jul 30, 2018

smadala Jul 30, 2018

singhsarab Jul 30, 2018

mayankbansal018 Jul 30, 2018

mayankbansal018 Jul 30, 2018

Find ISettingsProvider in TestAdapter assembly #1704

Find ISettingsProvider in TestAdapter assembly #1704

Conversation

smadala commented Jul 30, 2018 • edited Loading

Description

Related issue

mayankbansal018 Jul 30, 2018

Choose a reason for hiding this comment

smadala Jul 30, 2018

Choose a reason for hiding this comment

singhsarab Jul 30, 2018

Choose a reason for hiding this comment

mayankbansal018 Jul 30, 2018

Choose a reason for hiding this comment

mayankbansal018 Jul 30, 2018

Choose a reason for hiding this comment

smadala commented Jul 30, 2018 •

edited

Loading