Trx Logger Fixes #1710
Merged
Trx Logger Fixes #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaadhina
reviewed
Aug 2, 2018
| XmlTestStoreParameters parameters = XmlTestStoreParameters.GetParameters(); | ||
| XmlElement rootElement = helper.CreateRootElement("TestRun"); | ||
| // Create test run | ||
| if (this.testRun == null) |
There was a problem hiding this comment.
Please explain what scenario needs this
kaadhina
reviewed
Aug 2, 2018
| // (Trx viewer automatically adds In\<Guid> to the result file. | ||
| string fileName = Path.Combine(Environment.MachineName, Path.GetFileName(targetFileName)); | ||
| resultFiles.Add(fileName); | ||
| try |
There was a problem hiding this comment.
Did we hit any while validating?
There was a problem hiding this comment.
Related to issue #1705 TRX Logger shouldn't fail if test result attachments are missing/Invalid.
kaadhina
reviewed
Aug 2, 2018
| XmlTestStoreParameters parameters = XmlTestStoreParameters.GetParameters(); | ||
| XmlElement rootElement = helper.CreateRootElement("TestRun"); | ||
| // Create test run | ||
| if (this.testRun == null) |
There was a problem hiding this comment.
[](start = 0, length = 12)
Add UTs for this
kaadhina
reviewed
Aug 3, 2018
| XmlElement rootElement = helper.CreateRootElement("TestRun"); | ||
| // Create test run | ||
| // If abort occurs there is no call to TestResultHandler which results in testRun not created. | ||
| if (this.testRun == null) |
There was a problem hiding this comment.
Mention this happens when first batch itself aborts
kaadhina
reviewed
Aug 3, 2018
| @@ -515,6 +515,18 @@ public void TestResultHandlerShouldAddSingleTestEntryForOrderedTest() | |||
| Assert.AreEqual(this.testableTrxLogger.TestEntryCount, 1, "TestResultHandler is adding multiple test entries for ordered test."); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void TestRunCompleteHandlerShouldReportFailedOutcomeIfTestRunIsAborted() | |||
There was a problem hiding this comment.
can we add check for attachments
kaadhina
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trx Logger Fixes