Do not set connected event if Connection is Faulted #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankbansal018
changed the title
singhsarab
reviewed
Aug 13, 2018
| @@ -39,7 +39,7 @@ public ConnectedEventArgs(Exception faultException) | |||
| public ICommunicationChannel Channel { get; private set; } | |||
|
|
|||
| /// <summary> | |||
| /// Gets true if it's connected. | |||
| /// Gets a value indicating whether channel is connected or not true if it's connected. | |||
There was a problem hiding this comment.
Nit: Comma after connected or not.
| @@ -120,7 +120,11 @@ public int InitializeCommunication() | |||
| this.communicationEndpoint.Connected += (sender, args) => | |||
| { | |||
| this.channel = args.Channel; | |||
| this.connected.Set(); | |||
|
|
|||
There was a problem hiding this comment.
Do we need test for this ?
There was a problem hiding this comment.
I don't think so, it's a safe check, anyways args.Channel would be null, & we will just crash when we do TestRequestSender.CheckVersionWithTestHost().
There was a problem hiding this comment.
added tests
singhsarab
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deployed to remote machines testhost sometimes refuses connection, in such cases when we receive
Connection.IsFaulted = true, but we set connected event in TestRequestSender, which causes incorrect stack trace.Related issue
Fixes #1727