Move warning into a target to fix msbuild error #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes msbuild error "The <Warning> tag is no longer supported as a child of the <Project> element".
singhsarab
approved these changes
Dec 4, 2018
mayankbansal018
approved these changes
Dec 4, 2018
|
@ViktorHofer Can you please test with the latest pre-release package from myget feed: https://dotnet.myget.org/F/vstest/api/v3/index.json |
|
Sure but the latest pre-release package does not contain my changes: 16.0.0-preview-20181204-02 |
|
It's 16.0.0-preview-20181204-03 that should have it. |
|
Thanks. It works as expected, just tried it out in CI and locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes msbuild error
The <Warning> tag is no longer supported as a child of the <Project> element.Currently the Microsoft.Net.Test.Sdk nuget package can't be used with new msbuild versions as it throws if a Warning tag appears as a child of the Project element.. Found a related issue that talks about the change: dotnet/msbuild#3858. This issue already existed before my recent changes.
As the current package (https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/16.0.0-preview-20181128-01) is broken can we please publish a new one asap?
cc @singhsarab @mayankbansal018 @karanjitsingh