Fixing the timeouts. #1909
Merged
Fixing the timeouts. #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
singhsarab
commented
Feb 1, 2019
•
singhsarab
commented
- Made DesignModeClient timeout to connect to translation layer process configurable.
- Removed redundant timeouts
- ConnectionTimeout in VsTestConsoleWrapperAsync.
1. Made DesignModeClient timeout to connect to translation layer process configurable. 2. Removed redundant timeouts 3. ConnectionTimeout in VsTestConsoleWrapperAsync.
mayankbansal018
approved these changes
Feb 1, 2019
ShreyasRmsft
reviewed
Feb 3, 2019
| @@ -96,17 +95,27 @@ public void ConnectToClientAndProcessRequests(int port, ITestRequestManager test | |||
| EqtTrace.Info("Trying to connect to server on port : {0}", port); | |||
| this.communicationManager.SetupClientAsync(new IPEndPoint(IPAddress.Loopback, port)); | |||
|
|
|||
| var connectionTimeout = EnvironmentHelper.GetConnectionTimeout(); | |||
There was a problem hiding this comment.
can we change environemnt helper function to return a timespan?
singhsarab
added a commit
to singhsarab/vstest
that referenced
this pull request
Mar 5, 2019
* Fixing the timeouts. 1. Made DesignModeClient timeout to connect to translation layer process configurable. 2. Removed redundant timeouts 3. ConnectionTimeout in VsTestConsoleWrapperAsync. * Fixed the Acceptance tests related to Framework 3.5 changes
singhsarab
added a commit
that referenced
this pull request
Mar 5, 2019
* Translation Layer connection timeout (#1843) * Adding the missing assemblyInfo files and updating the copyrights (#1859) * Stop trying to connect if the test host exits unexpectedly (#1853) * Running NETFramework 3.5 in compat mode (#1906) * Fixing the timeouts. (#1909) * Fixing the connection timeout (#1910) * TestPlatform.PR (#1837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.