Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testhost.x86 large address aware #1986

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

sharwell
Copy link
Member

Fixes #1985

@sharwell sharwell marked this pull request as ready for review April 11, 2019 14:09
@sharwell sharwell changed the title Make testhost.x86 large address aware 🚧Make testhost.x86 large address aware Apr 11, 2019
@sharwell sharwell closed this Apr 11, 2019
@sharwell sharwell reopened this Apr 11, 2019
@mayankbansal018
Copy link
Contributor

@sharwell , I'm trying this out locally, making sure it doesn't break UWP scenario, will get back to you by eod.

@sharwell
Copy link
Member Author

@mayankbansal018 Thank you. I was expecting to need some sort of additional change since this pull request likely changes the output directory for these assemblies, but I was unable to decipher the build output to determine if/what the specifics were.

@mayankbansal018
Copy link
Contributor

@sharwell the PR doesn't change the output drop location, & I validated that even if we place testhost.dll compiled as exe for UWP projects, the tests still run fine.

Just a query regarding your comment #1985 (comment), do you mean the current testhost with LAA enabled after your changes crashes, or the one w/o LAA

@sharwell
Copy link
Member Author

the PR doesn't change the output drop location

Nice 👍

Just a query regarding your comment #1985 (comment), do you mean the current testhost with LAA enabled after your changes crashes, or the one w/o LAA

If I enable Server GC in the testhost.x86 that ships with Visual Studio (is not LAA), it runs out of memory.

This branch is out-of-date with the base branch
Merge the latest changes from master into this branch.

This is a GitHub repository configuration error that I can help with. I'll send you the details on MS Teams.

@sharwell sharwell changed the title 🚧Make testhost.x86 large address aware Make testhost.x86 large address aware Apr 18, 2019
@mayankbansal018
Copy link
Contributor

mayankbansal018 commented Apr 18, 2019

@sharwell , can you please merge the master into this branch
Generally github gives an option to merge master, but don't know why it is not coming on this PR

@sharwell
Copy link
Member Author

sharwell commented Apr 18, 2019

@sharwell , can you please merge the master into this branch

I sent you a message on MS Teams internally regarding this configuration error with the details on how to resolve it.

Generally git gives an option to merge master, but don't know why it is not coming on this PR

This button would require pushing a commit to my fork of this repository. I have always intentionally disabled this for all of my pull requests, though on rare occasions I enable it for single PRs after discussion.

@mayankbansal018 mayankbansal018 merged commit b53383b into microsoft:master Apr 18, 2019
@sharwell sharwell deleted the large-address-aware branch April 18, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testhost.x86 is not large address aware
2 participants