Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vstest.console Should not message to Testhost process if it has exited #1994

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Vstest.console Should not message to Testhost process if it has exited #1994

merged 2 commits into from
Apr 24, 2019

Conversation

mayankbansal018
Copy link
Contributor

@mayankbansal018 mayankbansal018 commented Apr 23, 2019

In very remote cases, esp while debugging if testhost process aborts for some unexpected reeason, & user also triggers a Cancel Request, then sometimes before vstest.console can mark the event testhostexited = true, we get request on another thread to cancel the run.

In this case since the communication with testhost has already expired, we fail to write to the tcp channel, which results in an exception being thrown in vstest.console. This exception is caught, but we also mark current vstest.console session to be completed, & the process dies, this results in further messages from IDE to not execute, for which user has to restart VS.

Bugs:
https://developercommunity.visualstudio.com/content/problem/508748/cant-run-any-test-from-test-explorer-writeandflush.html
https://developercommunity.visualstudio.com/content/problem/532712/occasional-ioexception-while-unit-testing.html
https://developercommunity.visualstudio.com/content/problem/499747/test-execution-fails-with-an-ioexception.html
https://developercommunity.visualstudio.com/content/problem/528897/error-running-unit-test-case.html

Log file:
log.txt

@mayankbansal018 mayankbansal018 merged commit 7dd4ef7 into microsoft:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants