Allow TranslationLayer to specify Diag parameters #296
Conversation
Log message for logging file of test host
| // Can only do this after InitializeCommunication because TestHost cannot "Send Log" unless communications are initialized | ||
| if (!string.IsNullOrEmpty(EqtTrace.LogFile)) | ||
| { | ||
| requestHandler.SendLog(TestMessageLevel.Informational, string.Format("Logging TestHost Diagnostics in file: {0}", EqtTrace.LogFile)); |
There was a problem hiding this comment.
This will show up in IDE, console runner. Does it require localization?
There was a problem hiding this comment.
No. It does not. It only shows up in IDE if diagnostics are enabled.
There was a problem hiding this comment.
And Manish's Verbose log is not localized - so we don't have to. With TestWindow, I am planning to add this if "VS_UTE_DIAGNOSTICS = 1" which definitely does not require localization.
| @@ -17,25 +17,30 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests | |||
| [TestClass] | |||
| public class VsTestConsoleWrapperTests | |||
| { | |||
| private readonly IVsTestConsoleWrapper consoleWrapper; | |||
| private IVsTestConsoleWrapper consoleWrapper; | |||
There was a problem hiding this comment.
Because we need to reinitialize these things in TestInitialize everytime to reset stuff.
There was a problem hiding this comment.
Why in test initialize? We could do those resets in constructor.
| { | ||
| new TestCase("a.b.c", new Uri("d://uri"), "a.dll"), | ||
| new TestCase("d.e.f", new Uri("g://uri"), "d.dll") | ||
| }; | ||
|
|
||
| public VsTestConsoleWrapperTests() | ||
| private ConsoleParameters consoleParamters; |
| { | ||
| return logFilePath; | ||
| } | ||
| set |
There was a problem hiding this comment.
nit: add a blank line before set.
There was a problem hiding this comment.
Why? - Is this a style cop/resharper thing?
Log message for logging file of test host