Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor cache timeout for discovery. #470

Merged
merged 4 commits into from
Feb 13, 2017

Conversation

AbhitejJohn
Copy link
Contributor

Nit fix to honor stats timeout instead of just passing max value. Since discovery is a very fast operation the batch size should be sufficient to trigger the discovery cache but just in case the batch size is made configurable and for some strange reason discovery is slow, this would help clear up the cache sooner.

…ce discovery is a very fast operation the batch size should be sufficient to trigger the discovery cache but just in case the batch size is made configurable and for some strange reason discovery is slow, this would help clear up the cache sooner.
@msftclas
Copy link

Hi @AbhitejJohn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Abhitej Anoop John Bandi). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Copy link
Contributor

@codito codito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

@codito
Copy link
Contributor

codito commented Feb 12, 2017

Since the variable is now used for both Discovery and Execution, we should rename it appropriately.

@AbhitejJohn AbhitejJohn merged commit 2316048 into microsoft:master Feb 13, 2017
@AbhitejJohn AbhitejJohn deleted the nitfixtohonordisctimeout branch February 13, 2017 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants