Make default testcase filter property name FullyQualifiedName #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smadala, |
codito
reviewed
Mar 2, 2017
| [CustomDataTestMethod] | ||
| [NET46TargetFramework] | ||
| [NETCORETargetFramework] | ||
| public void TestCaseFilterShouldWork_IfOnlyPropertyValueGivenInExpression(string runnerFramework, string targetFramework, string targetRuntime) |
There was a problem hiding this comment.
nit: please remove underscore
codito
reviewed
Mar 2, 2017
| string[] parts = Regex.Split(conditionString, propertyNameValueSeperatorString); | ||
| if (parts.Length == 1) |
There was a problem hiding this comment.
Isn't there an unit test for this?
There was a problem hiding this comment.
test is added in ConditionTests.cs.
codito
approved these changes
Mar 2, 2017
AbhitejJohn
approved these changes
Mar 2, 2017
| [NETCORETargetFramework] | ||
| public void TestCaseFilterShouldWork_IfOnlyPropertyValueGivenInExpression(string runnerFramework, string targetFramework, string targetRuntime) | ||
| { | ||
| AcceptanceTestBase.SetTestEnvironment(this.testEnvironment, runnerFramework, targetFramework, targetRuntime); |
There was a problem hiding this comment.
nit: Looks repetitive. Move to constructor/Test Init?
There was a problem hiding this comment.
We are using data row here, can't call from .ctor/Setup.
| { | ||
| var conditionString = "PropertyName="; | ||
| Assert.ThrowsException<FormatException>( ()=> Condition.Parse(conditionString)); | ||
| } |
| } | ||
|
|
||
| [TestMethod] | ||
| public void ParseShouldCreateDefaultCondition_WhenOnlyPropertyValuePassed() |
|
Related #334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet test --filter "ABC"todotnet test --filter "FullyQualifiedName~ABC".Related to: UX: dotnet-test filtering syntax is difficult to discover #334