Inject entry point only for project targeting netcoreapp #665
Conversation
Fix: Inject entry point only for project targeting netcoreapp1.0
|
@Faizan2304, |
There was a problem hiding this comment.
Suggestion : Maintain two separate copies for Microsoft.NET.Test.Sdk.targets for dotnet core and full clr Target Frameworks, This will avoid issues like #608 in future.
| @@ -18,7 +18,7 @@ | |||
| Generates Program file which contains the Main entry point | |||
| ============================================================ | |||
| --> | |||
| <PropertyGroup> | |||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'"> | |||
There was a problem hiding this comment.
A general thought (not specific to this PR):
For every build of a netcore test project, we will create this file. Does this imply that the test project will be compiled again always? (even if no actual code has changed)
If this is true, can it be avoided?
There was a problem hiding this comment.
No, It will create only first time. Subsequent build and rebuild will use the same
Issue: #608
Fix: Inject entry point only for project targeting netcoreapp