New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raygun Client using Activity reference for attaching pulse #46

Open

aurangzaibumer777 opened this issue Aug 2, 2018 · 1 comment

Labels

enhancement question

aurangzaibumer777 commented Aug 2, 2018 •

edited

Loading

RaygunClient.attachPulse(this); // taking an activity reference

Could'nt it use an applicationContext?

Since we attach it on SplashActivity meant it kept splashActivity alive throughout application lifecycle

using implementation 'com.mindscapehq.android:raygun4android:3.0.3' on build.gradle

Contributor

TheRealAgentK commented Sep 20, 2018

@aurangzaibumer777 That's good feedback, thx. I'm currently looking into making a bunch of changes to the provider and will consider this.

TheRealAgentK self-assigned this

TheRealAgentK added enhancement question labels

TheRealAgentK removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment