Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping issue - Raygun4js v3.1.0 #529

Closed
tahmernightingale opened this issue May 30, 2024 · 9 comments
Closed

Ping issue - Raygun4js v3.1.0 #529

tahmernightingale opened this issue May 30, 2024 · 9 comments

Comments

@tahmernightingale
Copy link

Raygun4js - v3.1.0 - 2024-05-30

var url = Raygun.Options._raygunApiUrl + "/ping?apiKey=" + encodeURIComponent(Raygun.Options._raygunApiKey);

Causing multiple 404's requests to

undefined/ping?apiKey=undefined

image

@CmdrKeen
Copy link
Contributor

For visibility: This has been escalated to the team to investigate.

@CmdrKeen
Copy link
Contributor

CmdrKeen commented May 30, 2024

We've reverted version 3.1.0 from our CDN to the prior version of 3.0.1.

You can verify the version loaded here.

3.1.0 was not yet pushed to any other package repositories or release sites.

Apologies for the issue. Thank you for reporting it too.

I won't close this ticket. Once the team have completed the investigation and code changes, they'll update with more detail (likely in the next 24 hours).

@tahmernightingale
Copy link
Author

Cheers mate, thanks for prompt replies

@Hamish-taylor
Copy link
Contributor

Hello,
We have been able to reproduce the issue, but to ensure that we have caught the exact scenario you encountered could you please share some additional details of your setup. It would be great if you could give us a screenshot of how you are setting up Raygun4js as well as other information such as if you are using a JavaScript framework. If you prefer you can send this info to our support team. Thanks!

@tahmernightingale
Copy link
Author

Hey Mate,

We are using the recommended async method for setup. No major JS Frameworks.

We have the script loading on every page, however we do not setup the apiKey on every page. I believe it is those pages that we haven't configured that were making the 404 requests.

// on some pages.

<script type="text/javascript"> rg4js('apiKey', 'paste_your_api_key_here'); rg4js('enablePulse', true); </script>

@Hamish-taylor
Copy link
Contributor

Thanks that helped a lot. The issue lies with how Raygun4js sets its self up internally. If no setup calls are made (such as setting the apiKey or enabling a product) then the default URL is not set which then caused the issues you encountered. We have implemented checks that will prevent the pings from being sent in these cases. Given that we are heading into the weekend we will wait until next week to deploy the new patched version.

Thank you for your help in identifying this issue

@tahmernightingale
Copy link
Author

Sweet, glad to help

@Hamish-taylor
Copy link
Contributor

Hey @tahmernightingale,

Just letting you know that we have published the patched version of 3.1.0 to the CDN. If you are curious you can find the fix in this PR.
We have also credited your account by the number of errors we caused.

Thank you again for your help!

@tahmernightingale
Copy link
Author

Cheers Hamish, looks good thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants