Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camille nightlies aren't published to NuGet #32

Open
aPinat opened this issue Feb 12, 2020 · 8 comments
Open

Camille nightlies aren't published to NuGet #32

aPinat opened this issue Feb 12, 2020 · 8 comments
Assignees

Comments

@aPinat
Copy link
Contributor

aPinat commented Feb 12, 2020

Camille.Enums for example is still missing new champions like Aphelios or Sett in the latest nightly release on NuGet.
CI still seams to be building nightly versions, but not deploying them when there are changes.

@MingweiSamuel
Copy link
Owner

Thanks for the report, I'll take a look today

@MingweiSamuel MingweiSamuel self-assigned this Feb 12, 2020
@MingweiSamuel
Copy link
Owner

Looks like I made a logical error in the build script, and also the deploy key expired. Fixed

Thanks for the report, let me know if there are any other issues

@aPinat
Copy link
Contributor Author

aPinat commented Oct 31, 2020

Currently the detection of changes seams to be broken again, as both the gh-pages branch and the newest NuGet nightly do not have Seraphine as new champion.

@aPinat
Copy link
Contributor Author

aPinat commented Jul 15, 2021

@MingweiSamuel Could you trigger a new build to add MingweiSamuel/riotapi-schema#26?

@MingweiSamuel
Copy link
Owner

Done. I set it up to trigger on enum updates although it still won't catch new champions if all else stays the same

@aPinat
Copy link
Contributor Author

aPinat commented Jul 15, 2021

But it didn't catch the ULTBOOK addition in the GameMode enum, and since you merged it 3 days ago it should've updated at some point in between then and your manual trigger, or am I understanding wrong?

@MingweiSamuel
Copy link
Owner

I just changed it to account for enum updates yesterday. Latest nightly has what you expect, right?

@aPinat
Copy link
Contributor Author

aPinat commented Jul 15, 2021

Ohhh I see.
Yes absolutely, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants