Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login issues in Glider app #63

Closed
Tintedfireglass opened this issue Jun 10, 2022 · 4 comments
Closed

Login issues in Glider app #63

Tintedfireglass opened this issue Jun 10, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@Tintedfireglass
Copy link

After I changed my HN password glider didn't automatically log me out and was throwing up errors like not able to upvote not able to comment, etc. So after logging out when I tried to log back in it says "failed to login"

Screenshot:

https://media.discordapp.net/attachments/799844115344785428/984858954737790976/Screenshot_20220610-220646-861.png

Other info:

Android 11

OS: Linux motorola/hanoip_retailnq/hanoip:11/RRI31.Q1-42-51-12/c157c:user/release-keys 11 - 30

Phone : Motorola g60

App version : latest update from Fdroid v. 1.16.1

Thanks :)

@Tintedfireglass
Copy link
Author

Tintedfireglass commented Jun 10, 2022

BTW, when I login to HN from web browser it asks me to solve a captcha. I think that is the problem as glider doesn't support it. (just a guess not sure if that's the real reason)

Edit :

Screenshot : https://media.discordapp.net/attachments/799844115344785428/985030709238448249/Screenshot_20220611-093004-845.png

Looks like it's gonna take a while for the captcha to go away..........

@Mosc
Copy link
Owner

Mosc commented Jun 10, 2022

Yeah, a CAPTCHA would certainly cause the login to fail. It's likely that the CAPTCHA was shown precisely because it was preceded by several failed requests with your old password. Luckily CAPTCHAs on HN are usually temporary.

So a couple things are going on here. Glider can not detect password changes on the website. What it could do is detect invalid credentials once a request has been made. Annoyingly, HN returns a 200 status code as if everything went fine, but the associated HTML does kind of mention that we are not logged in, so we could use this to trigger a logout. Also, although the app can not show CAPTCHAs, it could perhaps detect whether a login attempt has failed due to presence of a CAPTCHA in the HTML, and at least inform the user properly.

Finally, it might be best to change the way login data is retrieved and stored. Rather than asking for username and password in the app, we could present https://news.ycombinator.com/login to the user and just use the resulting cookie for further communication with HN. That would not only solve the CAPTCHA issue, but also prevent the user from having to trust the app with their password.

@Tintedfireglass
Copy link
Author

Finally, it might be best to change the way login data is retrieved and stored. Rather than asking for username and password in the app, we could present https://news.ycombinator.com/login to the user and just use the resulting cookie for further communication with HN. That would not only solve the CAPTCHA issue, but also prevent the user from having to trust the app with their password.

Yes,
That's a better way to handle password authentication

@Mosc Mosc added the bug Something isn't working label Jun 12, 2022
@Mosc
Copy link
Owner

Mosc commented Oct 23, 2023

The proposed structural fix has been implemented as of v2.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants