Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling issues in HN comments #86

Closed
Tintedfireglass opened this issue Mar 20, 2023 · 2 comments
Closed

Scrolling issues in HN comments #86

Tintedfireglass opened this issue Mar 20, 2023 · 2 comments
Labels
bug Something isn't working question Further information is requested

Comments

@Tintedfireglass
Copy link

Tintedfireglass commented Mar 20, 2023

1.When comments have been collapsed before all the subcomments load the UI goes into a frenzy trying to load and simultaneously collapse the thread making it unusable for a minute or so if your internet is slow

video :

https://media.discordapp.net/attachments/884641872008577064/1087443576511807599/screen-20230321-000156.mp4

2.Even when not collapsed the new loaded threads when loaded scroll the thread down making it unusable for slow internet connections

video :

https://media.discordapp.net/attachments/884641872008577064/1087444711704375377/screen-20230224-181640.mp42.mp4

as both issues are basically the same I combined them into one issue

I'm not sure how a workaround could be possible as the app is fundamentally designed in such a way that this is bound to occur.

thanks
:)

@Tintedfireglass Tintedfireglass changed the title Scrolling issues inHN comments Scrolling issues in HN comments Mar 20, 2023
@Mosc Mosc added the bug Something isn't working label Oct 23, 2023
@Mosc
Copy link
Owner

Mosc commented Oct 23, 2023

The first issue is a duplicate of #84, which should be solved by v2.0.0 due to the collapsing logic being rewritten.

The second issue is fair, but seems difficult to solve in a satisfactory way. We could just not render the thread until every comment has loaded, but that just makes the user wait for (possibly) a very long time. And although perhaps ideally we'd not have to split the loading over lots of different calls in the first place, this just happens to be the way that the Hacker News API is designed. Do you have any suggestions, even if you were to ignore the fundamental design?

@Mosc Mosc added the question Further information is requested label Nov 24, 2023
@Mosc
Copy link
Owner

Mosc commented Dec 11, 2023

Closing this for now. The first mentioned issue has been resolved, and the second issue, we've determined, is kind of inherent to the way comment trees are loaded. Still open to alternative suggestions though.

@Mosc Mosc closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants