Bug in AMWG diags: significance coder

[bertinia]

From @cecilehannay on April 21, 2017 20:45

Hi there -

I'm trying to run the AMWG, but it's dying when I turn on significance.

CODE_BASE
-- /glade/p/cesm/amwg/amwg_diagnostics

Error:
-- fatal:Undefined identifier: (get_PRECC_VARIANCE) is undefined, can't continue

Problem:
so I started poking around and it looks like the version of plot_surfaces_cons.ncl in SVN is different from the one on glade, which has these extra lines of code:

if (vars(i) .eq. "PRECC") then
A = get_PRECC (inptr1,outptr1)
if (sig_plot .eq. "True") then
A_var = get_PRECC_VARIANCE (meansptr1,varptr1)
end if
end if

if (vars(i) .eq. "PRECL") then
A = get_PRECL (inptr1,outptr1)
if (sig_plot .eq. "True") then
A_var = get_PRECL_VARIANCE (meansptr1,varptr1)
end if
end if

The problem is that funcs_surf_variance.ncl doesn't have a matching get_PRECC_VARIANCE function call.

Solution:
I guess either funcs_surf_variance.ncl needs a function call, OR these lines need to be removed from plot_surfaces_cons.ncl.

Thanks! (p.s., This is the problem file:)

-- /glade/p/cesm/amwg/amwg_diagnostics/code/plot_surfaces_cons.ncl

Copied from original issue: CESM-Development/cime#487

[bertinia]

From @gold2718 on April 21, 2017 21:57

@cecilehannay, This code is not in this repository, it is in NCAR/CESM_postprocessing. Please move this issue (and related issues) there so that issue number tracking works correctly.