Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for combining repetition_penalty, presence_penalty #274

Closed
richardliaw opened this issue Nov 3, 2023 · 1 comment
Closed

Support for combining repetition_penalty, presence_penalty #274

richardliaw opened this issue Nov 3, 2023 · 1 comment
Assignees
@byshiue @ncomly-nvidia @juney-nvidia
Labels
feature request New feature or request sampling triaged Issue has been triaged by maintainers

Comments

@richardliaw
Copy link

Currently support for these parameters are mutually exclusive. This makes it hard to create an OpenAI compatible API.

cc @akshay-anyscale @Yard1
@juney-nvidia juney-nvidia added triaged Issue has been triaged by maintainers feature request New feature or request labels Nov 4, 2023
@juney-nvidia juney-nvidia mentioned this issue Nov 5, 2023
Closed
@ncomly-nvidia ncomly-nvidia mentioned this issue Dec 11, 2023
Open
41 tasks
@kaiyux kaiyux mentioned this issue Dec 27, 2023
Merged
@kaiyux
Copy link
Member

kaiyux commented Dec 27, 2023

The support is included in the latest main branch, please see #754.

Closing. Please feel free to comment if you have any question, thanks!

@kaiyux kaiyux closed this as completed Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byshiue byshiue

@ncomly-nvidia ncomly-nvidia

@juney-nvidia juney-nvidia

Labels
feature request New feature or request sampling triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@richardliaw @byshiue @kaiyux @ncomly-nvidia @juney-nvidia