Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance machine configuration with internet type #1

Closed
CodyCBakerPhD opened this issue Jan 26, 2024 · 2 comments
Closed

Enhance machine configuration with internet type #1

CodyCBakerPhD opened this issue Jan 26, 2024 · 2 comments

Comments

@CodyCBakerPhD
Copy link
Collaborator

At a minimum, it could be an interactive CLI prompt asking the user to self-describe the internet connection they are current using

Though I'd really prefer it if we could in any way shape or form grab an identifier if possible

import socket
s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
s.connect(("8.8.8.8", 80))
ip_address = s.getsockname()[0]
s.close()

might do the trick? But perhaps we should still ask the user if they are OK with us grabbing and recording that info?

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jan 26, 2024
@rly
Copy link
Contributor

rly commented Feb 5, 2024

Perhaps this would be useful https://pypi.org/project/ifcfg/

@CodyCBakerPhD
Copy link
Collaborator Author

@oruebel mentioned maybe only the MAC address is the important thing

And to protect privacy we should only store a hash or encrypted string of that value to keep it unique but still identifiable/distinguishable from other result submitters

@CodyCBakerPhD CodyCBakerPhD removed their assignment Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants