Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with preloaded cache to test impact of caching on repeat operations #46

Open
oruebel opened this issue Apr 24, 2024 · 1 comment
Assignees

Comments

@oruebel
Copy link
Contributor

oruebel commented Apr 24, 2024

The current tests clean up the cache for fsspec and remfile between runs, so we only see the impact of the cache within the context of the specific operation (e.g, opening the file). It would be interesting to also add tests where we can see the impact of the cache when repeating the same operation with a previously initialized cache so that we can compare how much the cache can improve repeat operations.

One approach to implement this would be to:

  • Run the test case first in the setup to prime the cache and then
  • Repeat the same operation in the actual test function
@oruebel
Copy link
Contributor Author

oruebel commented Apr 24, 2024

@sinha-r we can add these after we have done a baseline run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants