Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm child attributes are generated within configured range #5

Open
Nevakanezah opened this issue Feb 12, 2020 · 1 comment
Open
Assignees
Labels
test Ensure things are working as intended

Comments

@Nevakanezah
Copy link
Owner

Nevakanezah commented Feb 12, 2020

Confirm that foals of all subtypes are spawning with attributes that fall within our expected range, as determined by the updated breeding formula.

Attributes are expected to fall within the range of:
LowestParent * skewMin% -> highestParent * skewMax%
and to be bounded within Minecraft's min and max for that stat, shown here:

Stat Min Max
Speed 0.1125 0.3375
Health 15 30
Jump 0.4 1.0

Llama strength is exempt here, as it's not currently modified by the plugin.
Genders like 'inbred' are also exempt, as they set specific attributes upon assignment.

@Nevakanezah Nevakanezah added the test Ensure things are working as intended label Feb 12, 2020
@Nevakanezah Nevakanezah added this to the 1.0 Release milestone Feb 12, 2020
@Nevakanezah Nevakanezah self-assigned this Feb 15, 2020
@Nevakanezah
Copy link
Owner Author

Turns out the custom attribute formula wasn't being called because SecretHorses had supplanted it while also doing nothing. This has been fixed in the latest checkin.

While manual testing has confirmed horse attributes are thusfar landing within accepted ranges (including cases with custom skew values), I'm working on getting my automated test code running in order to verify this more thoroughly.

@Nevakanezah Nevakanezah modified the milestones: 1.0 Release, Test Automation Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Ensure things are working as intended
Projects
None yet
Development

No branches or pull requests

1 participant