Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove target _blank #13

Open
jbampton opened this issue Jun 14, 2021 · 3 comments
Open

Remove target _blank #13

jbampton opened this issue Jun 14, 2021 · 3 comments
Labels
code style good first issue Good for newcomers hacktoberfest

Comments

@jbampton
Copy link
Collaborator

Not common practice anymore
@jbampton jbampton added the good first issue Good for newcomers label Jun 14, 2021
@BaseMax
Copy link
Member

BaseMax commented Jun 17, 2021

Not common practice anymore

Which link do you mean? Link to github profile at the network page?

@jbampton jbampton self-assigned this Mar 31, 2022
@jbampton
Copy link
Collaborator Author

There was this security risk. But I think it's also better to let the user decide how they want to open links.

https://stackoverflow.com/questions/50709625/link-with-target-blank-and-rel-noopener-noreferrer-still-vulnerable

@jbampton
Copy link
Collaborator Author

Seems this Gem adds the extra HTML. But still I like a choice as a user

Screen Shot 2022-07-26 at 6 01 39 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code style good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbampton @BaseMax