Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to choose specific resolution #100

Closed
hyuri opened this issue Mar 15, 2023 · 10 comments · Fixed by #240
Closed

[Feature Request] Ability to choose specific resolution #100

hyuri opened this issue Mar 15, 2023 · 10 comments · Fixed by #240
Assignees
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone

Comments

@hyuri
Copy link

hyuri commented Mar 15, 2023

Hi!

It would be great to be able to choose a specific resolution. Or at least have an indication, like "Best (4K)", "Good (1080p)" etc.

I often want to download the video in a specific resolution but I never know which resolution the words "Best", "Good", etc. refer to on any given video. Sometimes the highest resolution available for a video is 1080p, sometimes it is 4K but, for most of my use I almost never want to download the 4K version — or any higher than 1080p, actually.

@nlogozzo nlogozzo added the feature New feature or request label Mar 15, 2023
@nlogozzo nlogozzo added this to the V2023.3.1 milestone Mar 15, 2023
@fsobolev
Copy link
Member

@nlogozzo It is possible to get list of available resolutions from metadata, to avoid using static list with, for example, 4k resolution where the video actually is 720p at max.
And for audio files we can leave "Best" and "Worst" ("Good" is not needed, it's already an alias for "Best" when downloading audio).

@nlogozzo
Copy link
Member

nlogozzo commented Mar 15, 2023

It is possible to get list of available resolutions from metadata

Yes. Maybe we could get that list and show some options.

For example. for a 4K video we can have

Best = 4K
Good = 720
Worst = 480

For a 1080p video

Best = 1080
Good = 720
Worst = 480

For 720p:

Best = 720
Good = 480
Worst = 360

Just an idea

@fsobolev
Copy link
Member

I think we can simply have a full list of available resolution (except resolutions < 360p). Because in your plan you can't let the user choose whether to download 1080p, 720p (only one of them would be "Good") or 360p when the maximum resolution is 4k. Also it's absolutely not obvious what are actual resolutions.
I think the list of resolutions should not be considered as technical information, because most if not all video hosting services shows it like this, so a user is aware of what does it mean and "more human" terms are not required here.

@nlogozzo
Copy link
Member

Ok so switch the Quality field with a Resolution field and allow the user to simply pick the resolution they want to download.

@hyuri
Copy link
Author

hyuri commented Mar 15, 2023

Nice! Switching from Quality to Resolution seems like the simplest solution.

But in case you prefer to keep the Quality and "Best" | "Good" | "Worst" wording, maybe one of these could work:

  1. "Best (4K) | Good (1080p) | Good (720p) | Worst (480p)"
  2. "Best (4K) | Good (1080p) | Ok (720p) | Worst (480p)"

@nlogozzo
Copy link
Member

At that point, listing Best, Good, Ok, Worst, we might as well list the resolutions and let the user pick that :)

@hyuri
Copy link
Author

hyuri commented Mar 15, 2023

Perfect! :)

@DaPigGuy DaPigGuy self-assigned this Mar 19, 2023
@DaPigGuy
Copy link
Member

DaPigGuy commented Mar 20, 2023

Should Audio Quality options remain as Best, Good, and Worst?

@fsobolev
Copy link
Member

Should Audio Quality options remain as Best, Good, and Worst?

Best and Worst, Good was an alias for Best

@nlogozzo nlogozzo modified the milestones: V2023.3.1, V2023.4.0, V2023.4.1 Mar 27, 2023
@nlogozzo nlogozzo modified the milestones: V2023.4.1, V2023.4.2, V2023.4.3 Apr 12, 2023
@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label May 25, 2023
@nlogozzo
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
4 participants