Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember "Crop Thumbnail" setting #342

Closed
Batwam opened this issue Jun 10, 2023 · 4 comments · Fixed by #348
Closed

Remember "Crop Thumbnail" setting #342

Batwam opened this issue Jun 10, 2023 · 4 comments · Fixed by #348
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone

Comments

@Batwam
Copy link

Batwam commented Jun 10, 2023

Hello, would it be possible for TuberConverter to remember the "Crop Thumbnail" setting, ideally based on the extension used? as per the subtitle description for this Switch, the thumbnail crop is mostly useful for music so it would make sense to do that, or set it to enabled by default for sound filetypes like flac/wav/mp3/... (or mayb both, set to true by default for music files but remember when changed)

@nlogozzo nlogozzo added the feature New feature or request label Jun 10, 2023
@nlogozzo nlogozzo added this to the V2023.6.1 milestone Jun 10, 2023
@nlogozzo
Copy link
Member

@fsobolev How do you think we should implement this? We can either remember the Crop Thumbnail setting per extension, like @Batwam suggested. But the problem I have with this is that Crop Thumbnail is an Advanced Option and I don't want people to forget that they have this turned on since, compared to Number Video Titles and Resolution that are saved, this option isn't visible on the main screen.

What I was thinking is maybe to have an option in Preferences under the Converter section, probably even expanded under Embed Metadata, called Automatically crop audio thumbnails as square (off by default), that if on, will turn Crop Thumbnail on if an audio extension is selected.

@fsobolev
Copy link
Member

I think ideally there shouldn't be a separate advanced options page, but without it either the dialog would have too much height, or we would have to use wider dialog and lose adaptiveness. So I think this:

What I was thinking is maybe to have an option in Preferences under the Converter section, probably even expanded under Embed Metadata, called Automatically crop audio thumbnails as square (off by default), that if on, will turn Crop Thumbnail on if an audio extension is selected.

is the best option.

@nlogozzo
Copy link
Member

nlogozzo commented Jun 11, 2023

image

@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Jun 13, 2023
@nlogozzo
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants