Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenNMT-py code #19

Open
ruohoruotsi opened this issue Apr 17, 2020 · 0 comments
Open

Remove OpenNMT-py code #19

ruohoruotsi opened this issue Apr 17, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ruohoruotsi
Copy link
Member

  • Since OpenNMT-py is now on PyPI, we don't need to keep a full fork of the src in src/onmt

  • We do need scorers and other utilities (like code to prepare a model for release, stripping out optimizer info and keeping only model weights and biases)

TODO:
Refactor top level scripts and code in src to use a pip installed OpenNMT-py for training and evaluation, using only the custom scoring and utils source where necessary.

@ruohoruotsi ruohoruotsi added the enhancement New feature or request label Apr 17, 2020
@ruohoruotsi ruohoruotsi self-assigned this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant