Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move asserts definition to crypto3 #583

Open
3 tasks
makxenov opened this issue Mar 26, 2024 · 2 comments
Open
3 tasks

Move asserts definition to crypto3 #583

makxenov opened this issue Mar 26, 2024 · 2 comments
Assignees

Comments

@makxenov
Copy link
Contributor

makxenov commented Mar 26, 2024

Asserts from assigner could be used in another repositories as well, so we decided to move it to crypto3. Required steps:

@makxenov makxenov self-assigned this Mar 26, 2024
@aleasims
Copy link
Contributor

It would be nice also to have this variant of todo function as well:

void todo(const std::string &msg, const char *filename, unsigned line);

Right now you can't write:

std::string s("world");
TODO("hello " + s);

I missed this variant when I was implementing this.

@aleasims
Copy link
Contributor

aleasims commented Apr 8, 2024

We have some custom asserts defined in zkllvm-blueprint as well (here). Maybe we can replace them also. Blueprint is already using crypto3 library anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants