Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closure size: strongswan depends on GCC #26159

Closed
lheckemann opened this issue May 27, 2017 · 7 comments
Closed

closure size: strongswan depends on GCC #26159

lheckemann opened this issue May 27, 2017 · 7 comments

Comments

@lheckemann
Copy link
Member

Issue description

This bloats the closure of networkmanager-applet.

Technical details

  • System: 17.03.1203.58e227052d (Gorilla)
  • Nix version: nix-env (Nix) 1.11.8
  • Nixpkgs version: "17.03.1203.58e227052d"
  • Sandboxing enabled: true
@lheckemann
Copy link
Member Author

lheckemann commented May 28, 2017

Caused, by the looks of it, by adb831e which was added to fix #4925.

@vcunat
Copy link
Member

vcunat commented May 28, 2017

-lgcc_s only adds ${gcc.lib} which is < 5 MB. EDIT: we also have this one in glibc.out.

@lheckemann
Copy link
Member Author

Alright, not that then. My bad!

@vcunat
Copy link
Member

vcunat commented May 28, 2017

dontPatchELF = true; leads to RPATHS not being shrinked, though I'm not sure how it gets stuff like ${gcc}/libexec/gcc/x86_64-unknown-linux-gnu/5.4.0 into RPATH anyway.

@dezgeg
Copy link
Contributor

dezgeg commented May 29, 2017

Just for note, this is the cause of dontPatchELF: NixOS/patchelf#45. Seems quite hard to fix in patchelf, most likely the package source should be checked if the export of the lib symbol is intentional, which I doubt it is.

@dezgeg
Copy link
Contributor

dezgeg commented May 29, 2017

Bah, there apparently is deliberately a global variable named lib in strongswan...

@vcunat
Copy link
Member

vcunat commented Sep 5, 2018

It seems OK now.

$ nix path-info -rf. strongswan | xargs du -sc | sort -n
...
2616    /nix/store/mdm7f4mka3dqdkvj1nz8gckzzad1hqqq-iptables-1.6.2
3516    /nix/store/10lh4y4japz71ilb0yidzc9s5krhadnw-db-4.8.30
3616    /nix/store/9kr8r78bwk12050ppywfbhg1vrsd6dp8-openssl-1.0.2p
4536    /nix/store/7kg61ssbxfnqws8smp81k87ld1ir9i71-strongswan-5.6.3
5636    /nix/store/zk5zj2307zxaq7dx585yia3dn5k4qlsl-gcc-7.3.0-lib
8496    /nix/store/gj5qw8c2ji9cpa600gf1yxwcf3k89v98-openssl-1.1.0i
10772   /nix/store/wm8va53fh5158ipi0ic9gir64hrvqv1z-coreutils-8.29
26428   /nix/store/fg4yq8i8wd08xg3fy58l6q73cjy8hjr2-glibc-2.27
84184   total

@vcunat vcunat closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants