Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocatable binaries not handled #536

Open
infinisil opened this issue Nov 26, 2023 · 0 comments
Open

Relocatable binaries not handled #536

infinisil opened this issue Nov 26, 2023 · 0 comments
Labels

Comments

@infinisil
Copy link
Member

Describe the bug

Relocatable binaries aren't processed and give an error.

Offending code:

patchelf/src/patchelf.cc

Lines 281 to 282 in 917ea45

if (rdi(hdr()->e_type) != ET_EXEC && rdi(hdr()->e_type) != ET_DYN)
error("wrong ELF type");

Missing handling of ET_REL (see ELF headers)

A clear and concise description of what the bug is.

Steps To Reproduce

See: https://hydra.nixos.org/build/241099651/nixlog/1

Expected behavior

Maybe they should also be processed, but I'm not sure

patchelf --version output

patchelf 0.15.0

Additional context

Found by @prtzl and @fricklerhandwerk at #ZurichZHF :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant