Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Implement benchmark for CPU and GPU for linear algebra, arithmetic and initializer methods #57

Open
2 of 5 tasks
henrique-borba opened this issue Jul 8, 2024 · 4 comments · Fixed by #63
Open
2 of 5 tasks
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@henrique-borba
Copy link
Member

henrique-borba commented Jul 8, 2024

Create the benchmark using phpbench (https://github.com/phpbench/phpbench), a solid and well-maintained tool.

@henrique-borba henrique-borba added the enhancement New feature or request label Jul 8, 2024
@henrique-borba henrique-borba added this to the 0.6.0 milestone Jul 8, 2024
@henrique-borba henrique-borba added the good first issue Good for newcomers label Jul 8, 2024
@jiyo4476
Copy link
Contributor

jiyo4476 commented Jul 9, 2024

I would like to contribute and work on this feature

@henrique-borba
Copy link
Member Author

henrique-borba commented Jul 11, 2024

Nice @jiyo4476, thanks!

You can start with the initializers first so we can discuss a pattern and see what it looks like.

I was thinking of 3 matrices of sizes 10x100, 1000x500 and 10000x1000 and 3 vectors of size 100, 500, 1000 elements. This way we could also use it to identify algorithms that are potentially less performant with larger/smaller arrays.

When you want me to take a look, you can open the merge request. Ignore the merge request template guidelines as this issue does not apply.

@henrique-borba henrique-borba removed this from the 0.6.0 milestone Jul 11, 2024
@jiyo4476
Copy link
Contributor

jiyo4476 commented Jul 15, 2024

Thank you! @henrique-borba

I created a new branch at https://github.com/jiyo4476/numpower and submitted a pull request.
I added a composer.json file and installed dependencies with composer install.

Then I ran the benchmarks using
./vendor/bin/phpbench run benchmarks/initializers --report=aggregate

Currently, I only ran the tests with the compilation for CPU. I wanted to make sure I was adding the benchmarks correctly.

@henrique-borba
Copy link
Member Author

I was focused on update 0.6.0 but now I'm going to prioritize your MR.

Thanks again @jiyo4476

@henrique-borba henrique-borba linked a pull request Jul 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants