Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no choice for Caitiff #1

Open
CalumWulfe opened this issue Jan 17, 2024 · 2 comments
Open

no choice for Caitiff #1

CalumWulfe opened this issue Jan 17, 2024 · 2 comments
Assignees

Comments

@CalumWulfe
Copy link

noticed there's not option to be a Caitiff/Clan-less

@Fiobrum
Copy link

Fiobrum commented Feb 13, 2024

thats litterly so true... I may be gonna look for it to code but I dont have enough time for this rn...

@Odin94
Copy link
Owner

Odin94 commented Jul 13, 2024

Hi! The reason I didn't add Caitiff (yet) is that they don't have clan-specific disciplines and because of that the Discipline picking page would need to work differently for them.

If you (or anyone else) want to contribute a PR to add Caitiff, it'd be cool if you did something like:

  • Add a clanDisciplines attribute to the Character type
  • In DisciplinePicker, replace the call to getDisciplinesForClan(character.clan) with character.clanDisciplines
  • Set clanDisciplines on character to getDisciplinesForClan(character.clan) when picking a Clan
  • When picking Caitiff, open a modal for picking your disciplines (inspiration code for the modal can be found in PredatorTypeModal.tsx) and assign the picked disciplines instead of getDisciplinesForClan(character.clan)

Also let me know ahead of time if you want to work on this and give me a rough timeline on completion, just so nobody else (or I myself) works on it at the same time and we do duplicate work :)

@Odin94 Odin94 self-assigned this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants