-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOE Implementation is complicated #63
Comments
Good input, looking forward to your pull-request. |
The changes make sense, makes me think if we should take the opportunity. I was wondering if, since we plan to change the APi abit, also should add a foe_read_cfg? |
Sorry I was on vacation. Regarding the foe_read_cfg I think is not needed it can be fully covered from the current implementation. Instead I would propose to implement some kind of read/write access flags that belong to the file struct/class that will allow you to make something readable/writable and also define in which etherCAT state this is allowed so the FOE library can report the foe errors and AL_STATU_CODE erros like (NOT_IN_BOOTSTRAP) |
Also I am planning to be in frankfurt for the ETG event |
make sense and would be simple enough, can you give it a try and update the PR. I can test if we get the code in place. I've to pass TC meeting, quite busy in projects. |
@elsp1991 , did you get a chance to look at concluding this patch with read support? |
@nakarlsson, I did had a look a while ago. Firstly I changed the read function cause was reading from the wrong memory address causing lockup, but then I was busy to continue. |
Hi @elsp1991, any update? have you had time to finalize it? |
Hi @nakarlsson unfortunately I am still in the same state as I described above. |
Going through the esc_foe files I found out some issues:
The text was updated successfully, but these errors were encountered: