Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a build argument or env to skip the generation of default keystore and truststore config #398

Open
leochr opened this issue May 3, 2023 · 2 comments · May be fixed by #434
Open
Assignees

Comments

@leochr
Copy link
Member

leochr commented May 3, 2023

Liberty container image includes scripts (configure.sh, startup) that generate the default keystore. It's added to /config/configDropins/defaults. Provide a build arg/env to skip the generation of the default keystore

Relevant issue: WASdev/ci.docker#493 (comment)

Also, consider providing an option to skip the generation of the default truststore. The default truststore.xml is written to configDropons/overrides, not sure what the historical reason is. This would override the user-specified truststore config in server.xml as well.

@leochr leochr changed the title Consider a build argument or env to skip the generation of default keystore Consider a build argument or env to skip the generation of default keystore and truststore May 3, 2023
@leochr leochr changed the title Consider a build argument or env to skip the generation of default keystore and truststore Consider a build argument or env to skip the generation of default keystore and truststore config May 3, 2023
@pugmas
Copy link

pugmas commented May 4, 2023

Hi @leochr ,
maybe I'm wrong, but isn't there already an environment variable for this?

ENV KEYSTORE_REQUIRED "false"

https://hub.docker.com/_/open-liberty

@leochr
Copy link
Member Author

leochr commented May 9, 2023

@pugmas That env variable must have existed in previous tags (i.e. webProfile), but the current set of images with kernel-slim and full tags don't include/support it.

@kabicin kabicin self-assigned this Jul 27, 2023
@kabicin kabicin linked a pull request Jul 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants