Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gesture navigation: Hold to stop not working #1893

Open
mroethke opened this issue Apr 15, 2024 · 10 comments
Open

Gesture navigation: Hold to stop not working #1893

mroethke opened this issue Apr 15, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@mroethke
Copy link

Describe the bug
I can't stop a recording because hold to stop is not working. If I just tap it the message "Hold to stop" is displayed.
In some rare situations it does work, but i cant reproduce that.
I usually help myself by stopping the app in settings but, that is hardly a solution.

To Reproduce

  1. Start recording
  2. Hold touch on stop button
  3. Recording does not stop

Technical information

  • Device: FP3
  • OS: LineageOS 20
  • OpenTracks version: v4.12.1 (fdroid)
@mroethke mroethke added the potential bug A bug that could not (yet) be reproduced label Apr 15, 2024
@dennisguse
Copy link
Member

Just keep the button pressed ;)

@dennisguse dennisguse closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
@mroethke
Copy link
Author

thank you for your suggenstion, but I tried that. It does not work no matter how long i press.

@dennisguse
Copy link
Member

Can you upload a video?

@mroethke
Copy link
Author

sure
itdoesnotwork.webm

@dennisguse dennisguse reopened this Apr 17, 2024
@dennisguse
Copy link
Member

Interesting :)
Some wild guessing: can you try it with 3-button navigation?
And also check that you are not touching the gesture bar directly below?

It is one of the those "works for me" situations 😎

@mroethke
Copy link
Author

It works with 2 and 3 button navigation so it is probably androids fault. I'm pretty sure that it worked flawlessly at some point with gesture navigation though, since I have been using it for years.
However, by aiming for the upper left quarter of the button I can somewhat reliably stop the recording. That is not great, but at least it is something. (I really really like gesture navigation and don't want to switch back)

I have two ideas on how to make this better:

  1. Can you change the color of the button when it registers the touch event? this way it would at least be clear to me that the app does or does not register an event.
  2. Could the button be moved a bit towards the center of the screen to make the area were it registers the touch event larger?

I realize that the second one would probably not be very popular since it would waste some screen space for a problem that apparently not many people have. And it is just a workaround for something I would consider to be an android bug. I do wonder if using this API would change anything tough, if it is not already used.

@dennisguse
Copy link
Member

Finally, I got to use it: "You are holding it wrong!" 🥳
So, now I can strike this from my bucket list.

Anyhow, can you try to solve this on your own?
I am kind of busy with other side projects at the moment and nothing would happen here soonish.

@dennisguse
Copy link
Member

@mroethke
Copy link
Author

I'm sorry, but I did not mean to imply that I would work on it. I can see why you assumed that, but it really was not my intention.
I unfortunately have zero experience with android app development :/

@dennisguse dennisguse added bug Something isn't working and removed potential bug A bug that could not (yet) be reproduced labels Apr 25, 2024
@dennisguse dennisguse changed the title Hold to stop not working Gesture navigation: Hold to stop not working Apr 25, 2024
@dennisguse
Copy link
Member

@mroethke no worries about this!
My biggest problem is that I cannot reproduce the problem easily on my Fairphone 4.
Eventually, this will be fixed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants