Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing OVOSLangTranslationFactory mapping #8

Closed
atd opened this issue Jun 4, 2023 · 5 comments
Closed

Missing OVOSLangTranslationFactory mapping #8

atd opened this issue Jun 4, 2023 · 5 comments

Comments

@atd
Copy link

atd commented Jun 4, 2023

I dockerized this pluging, following the examples in ovos-docker repo

When starting, I get this error

Seems like a translation configuration is missing? Is it needed? (chatpgt knows how to speak in several languages)

ovos_skill_fallback_chatgpt  | 2023-06-04 20:06:28.830 - OVOS - ovos_plugin_manager.utils:load_plugin:146 - WARNING - Could no
t find the plugin PluginTypes.TRANSLATE.libretranslate_plug                                                                   
ovos_skill_fallback_chatgpt  | 2023-06-04 20:06:28.831 - skill-ovos-fallback-chatgpt.openvoiceos - ERROR - Skill initializatio
n failed                                                                                                                      
ovos_skill_fallback_chatgpt  | Traceback (most recent call last):
ovos_skill_fallback_chatgpt  |   File "/usr/lib/python3.11/site-packages/ovos_workshop/skills/base.py", line 412, in _startup
ovos_skill_fallback_chatgpt  |     self.initialize()
ovos_skill_fallback_chatgpt  |   File "/home/ovos/.local/lib/python3.11/site-packages/skill_ovos_fallback_chatgpt/__init__.py"
, line 35, in initialize
ovos_skill_fallback_chatgpt  |     self._chat = OpenAIPersonaSolver(config=self.settings)
ovos_skill_fallback_chatgpt  |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ovos_skill_fallback_chatgpt  |   File "/home/ovos/.local/lib/python3.11/site-packages/ovos_solver_openai_persona/__init__.py",
 line 9, in __init__
ovos_skill_fallback_chatgpt  |     super().__init__(name="OpenAI ChatGPT Persona", config=config)
ovos_skill_fallback_chatgpt  |   File "/home/ovos/.local/lib/python3.11/site-packages/ovos_solver_openai_persona/engines.py", 
line 57, in __init__
ovos_skill_fallback_chatgpt  |     super().__init__(name=name, priority=25, config=config,
ovos_skill_fallback_chatgpt  |   File "/usr/lib/python3.11/site-packages/ovos_plugin_manager/templates/solvers.py", line 34, i
n __init__
ovos_skill_fallback_chatgpt  |     self.translator = OVOSLangTranslationFactory.create()
ovos_skill_fallback_chatgpt  |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ovos_skill_fallback_chatgpt  |   File "/usr/lib/python3.11/site-packages/ovos_plugin_manager/language.py", line 185, in create
ovos_skill_fallback_chatgpt  |     raise ValueError
ovos_skill_fallback_chatgpt  | ValueError
@atd
Copy link
Author

atd commented Jun 4, 2023

pip3 install neon-lang-plugin-libretranslate did the trick. Maybe add it to requirements.txt?

@goldyfruit
Copy link
Member

@JarbasAl is this should be a requirements of this skill or should I install neon-lang-plugin-libretranslate by default in ovos_core container?

@JarbasAl
Copy link
Member

the translation plugin is configurable globally, it should not be a requirement of individual plugin but of core

we dont have a good default yet, so we just use the neon hosted libretrabslate (anyone can host it)

we should use a offline alternative, such as https://github.com/OpenVoiceOS/ovos-translate-plugin-nllb

@goldyfruit
Copy link
Member

the translation plugin is configurable globally, it should not be a requirement of individual plugin but of core

we dont have a good default yet, so we just use the neon hosted libretrabslate (anyone can host it)

we should use a offline alternative, such as https://github.com/OpenVoiceOS/ovos-translate-plugin-nllb

For now, I going with neon-lang-plugin-libretranslate in ovos_core and ovos_skill_base.

@JarbasAl
Copy link
Member

we now have translation servers and a default plugin, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants