No DB migration for data type change from TIMESTAMP to CHAR(32) for OXTIMESTAMP

[TiiFuchs]

In the fcpayone_events.php the OXTIMESTAMP columns are created as CHAR(32):

oxid-6/core/fcpayone_events.php

Line 78 in dc2f45a

OXTIMESTAMP CHAR(32) COLLATE latin1_general_ci NOT NULL DEFAULT '',

But the UPDATE statements change them to TIMESTAMP...

oxid-6/core/fcpayone_events.php

Line 655 in dc2f45a

self::changeColumnTypeIfWrong($table, 'OXTIMESTAMP', 'TIMESTAMP', str_replace('[REPLACE_WITH_TABLE_NAME]', $table, self::$sQueryChangeOxtimestampType));

and

oxid-6/core/fcpayone_events.php

Line 391 in dc2f45a

public static $sQueryChangeOxtimestampType = "ALTER TABLE [REPLACE_WITH_TABLE_NAME] CHANGE OXTIMESTAMP OXTIMESTAMP TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'Timestamp';";

I think there is a migration missing for changing it to CHAR(32)?

btw: Why are you using CHAR(32) for this?

[vanilla-thunder]

i am also wondering, why oxtimestamp data type was changed to char(32) in november 2020
fbd1c2f

also the FCPO_REFERENCE was changed from char(32) to int(11) but if you are upgrading, then you already have rows with alphanumerical values there, so you cant simply import old data anymore.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.