Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adress check triggers by default for direct debit, admin page was removed [v1.9.0] #270

Open
bYemma opened this issue Jun 14, 2023 · 2 comments
Labels

Comments

@bYemma
Copy link

bYemma commented Jun 14, 2023

if(oForm.fcpo_checktype && oForm.fcpo_checktype.value == '-1') {
oForm.submit();
return false;

This passage in the JS code refers to a config entry which has been removed in the current version of the module.

fcpo_checktype is populated via the payment controller with the config entry sFCPOPOSCheck. The possibility to set this value has been on the admin page "PAYONE Configuration" -> "Protect" under "Address check", which has been removed from the module.

/**
* Get config parameter sFCPOPOSCheck
*
* @return string
*/
public function getChecktype()
{
return $this->getConfigParam('sFCPOPOSCheck');
}

The admin page was removed on update v1.8.0...v1.9.0

Since the setting option has been removed, the request for the address check should also be removed from the Javascript file.

Currently the config entry is empty, which results in the address check always being executed. A workaround is to manually set the config entry to "-1" to disable the check for direct debit until the problem is fixed.

The problem usually only occurs when you install the module afresh, because then the config entry sFCPOPOSCheck is not present and therefore empty. If you update the old module, the entry is already in the database if the setting was set before.

@stale
Copy link

stale bot commented Aug 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant