Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding the transport equation onto the sphere #2

Open
GuillaumeBriand opened this issue Feb 16, 2023 · 1 comment
Open

Regarding the transport equation onto the sphere #2

GuillaumeBriand opened this issue Feb 16, 2023 · 1 comment

Comments

@GuillaumeBriand
Copy link
Collaborator

Hello everyone,

I would like to open the question regarding the correction to be made to solve the equation in spherical coordinates (latitude, longitude).
This should be improved mass conservation.
How should we proceed ?

Guillaume

@innasenina
Copy link
Collaborator

Hello Guillaume,

That’s great and timely! To reply to your question, please integrate these changes into the development branch and provide related documentation. We can then review the changes together and merge them with the master branch via pull request.

Regarding documentation for the change, since the transition from the regular grid on the 2D plane to the quadrilateral grid on the sphere surface represents a critical change of the model numerical scheme, basically it should be entirely rewritten, it will be necessary to update the reference manual as well. Unless you did this already, I suggest that we do this as the next step, and for now we will need to revise only the essential changes, i.e., the partial derivatives approximation (section 2.2.3 of the manual) in the spherical coordinates, and, ideally, the updated approximation of the model equations (section 2.2.4).

Note that the development branch is behind the master, so before introducing any modifications, please update it from master. Or, perhaps, we can make abother branch specifically for this issue/change. Let me know what you prefer and if you need help with anything.

Cheers,
Inna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants