Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Correlated Query Implementation #37

Open
psbrandt opened this issue Jan 24, 2020 · 0 comments
Open

Improve Correlated Query Implementation #37

psbrandt opened this issue Jan 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@psbrandt
Copy link
Member

Right now our correlated query implementation is pretty limited. We only support a single relationship, and we match on specific resource/attribute pairs.

I think the more correct way to do this is to push aliases onto a stack in the context, and then process the where clause as a normal expression. This would eliminate the need for special resource/attribute pair matching and would re-use all the code we already have for expression translation.

When processing the where expression, when we encounter an alias reference, we would able to resolve this by peeking into the stack in the context. Basically, aliases are noted and resolved like any other reference.

@psbrandt psbrandt added the enhancement New feature or request label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant