Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/asis doesn't respect Accept-Encoding #32

Open
dooman87 opened this issue Sep 2, 2021 · 0 comments
Open

/asis doesn't respect Accept-Encoding #32

dooman87 opened this issue Sep 2, 2021 · 0 comments
Labels

Comments

@dooman87
Copy link
Collaborator

dooman87 commented Sep 2, 2021

https://pixboost.com/img/v2/homepage/animation-js.svg - hitting this SVG directly from Chrome will serve gzipped version less than 100Kb

Hitting the same URL from transformimgs will serve uncompressed version ~450Kb:

http://localhost:8080/api/img/https://pixboost.com/img/v2/homepage/animation-js.svg/asis

When implementing:

  • Do not forget to add Accept-Encoding into Vary header
  • Consider where to server Encoding header into response - probably just proxy
@dooman87 dooman87 added the bug label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant