-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rare fatal error caused by ActionScheduler not installing correctly #853
Comments
@fpcorso So I have been tracking this one for a week or so trying to figure out what is going on. Seems its not related to us at all, but rather the current release of Action Scheduler. It is affecting WooCommerce as well:
I haven't been able to make a determination yet but I believe its related to the create table query having something not quite right, at least for the version of MySQL these users are using. Specifically I noted this comment in one of those issues:
Strangely I have encountered that when working on the new analytics tables on MySQL 5.7. But this leads me to think that woocommerce/action-scheduler#587 is the true root of this. So I need to review my commits and see if I can work out what might be the cause here as well. |
Ahh yes I remember: https://stackoverflow.com/questions/36882149/error-1067-42000-invalid-default-value-for-created-at Its an sql_mode that causes this issue. I think I ended up switching to |
@danieliser Seems the Action Scheduler package hasn't resolved this issue yet. If I get the other issues in 1.11.1 fixed, we may need to punt this one to the next hotfix release. |
@fpcorso - one option is to manually make the tweaks after That way our users can avoid the errors in the mean time. |
Added notes about potential changes to resolve this here: woocommerce/action-scheduler#587 (comment) |
@fpcorso There seems to be some hope, other plugins have found workarounds for their users, and this one shows the workaround but also says they fixed it, haven't read the full details or looked at the code, but good place to start on solving it maybe: https://wordpress.org/support/topic/plugin-is-not-working-after-upgrade-please-fix-asap/ |
@danieliser I reviewed that support topic thread (which is two pages) but some users continued to experience the issue even after updating. However, they did say if the user went to |
@fpcorso WooCommerce suggested the same thing, somehow visiting that page causes it to recheck tables and install them again. But if the plugin fatals on install, it doesn't much matter haha. That said I do wonder if the users experiencing this have WP_DEBUG enabled. |
@tonyfelice Appreciate the feedback. So it could be related to table prefixes you think? |
Whatever the issue, it’s with the scheduler, not Popup Maker. After I had emailed, I tried to install Automatik’s standalone scheduler, and I’ve never seen Wordpress puke harder ;-)
(tf)
… On Feb 1, 2021, at 11:57 PM, Daniel L. Iser ***@***.***> wrote:
@tonyfelice Appreciate the feedback. So it could be related to table prefixes you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@tonyfelice We may end up just removing our usage of it and finding an alternative. It seemed like it should be a super reliable choice early on since its maintained by WooCommerce, but sigh. |
Describe the bug
A few admins have reported an error occurring when the plugin is updated or first installed that appears to be coming from within Action Scheduler. Will update here as we have more info.
Site information
Popup Maker version: 1.11.0
Errors
One Admin reported this error in the forums here: https://wordpress.org/support/topic/version-1-11-breaks-my-site/
Another admin reported this stacktrace in the forums here: https://wordpress.org/support/topic/critical-error-after-update-4/#post-13124120
The text was updated successfully, but these errors were encountered: