Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dang-math function names. #72

Open
Possseidon opened this issue Feb 22, 2022 · 0 comments
Open

Improve dang-math function names. #72

Possseidon opened this issue Feb 22, 2022 · 0 comments
Assignees
Labels
dang-lua dang-math refactor Changing stuff without introducing new features

Comments

@Possseidon
Copy link
Owner

This is regarding function names such as:

Vector::normalize();

From the name of the function, one might expect this to normalize the vector in place, however a new vector is returned instead. A better name (albeit slightly longer) would therefore be normalized.

Go through the entirety of dang-math and fix the names.

Also update Lua bindings:

  • Use properties for functions such as normalized or solvable.
  • Add getNormalized or isSolvable methods to still allow use in a functional sense.
@Possseidon Possseidon added dang-lua dang-math refactor Changing stuff without introducing new features labels Feb 22, 2022
@Possseidon Possseidon self-assigned this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dang-lua dang-math refactor Changing stuff without introducing new features
Projects
None yet
Development

No branches or pull requests

1 participant