"Show changes" doesn't show edit window and buttons below the changes #319

stefahn · 2022-03-15T09:28:31Z

For editing pages I use action=formedit and the extensions PageForms, VirtualEditor and VEForAll. After clicking "Show changes" the changes are shown. But below there is no edit window and there are no buttons.

When I switch to the Vector skin the edit window and the buttons show up as expected. So I figured it might be a Chameleon issue.

Using MediaWiki 1.35.5, Chameleon 4.0.0, the latest master versions of PageForms and VEForAll, and the latest version of VirtualEditor 1_35 branch.

The text was updated successfully, but these errors were encountered:

WouterRademaker · 2022-03-15T13:23:40Z

The same with MediaWiki 1.37.1, Chameleon 4.0.0 and Page Forms 5.3.4

malberts · 2022-03-26T11:51:22Z

I reproduced this on a clean wiki with:

MW 1.37.1
Chameleon (master)
Page Forms (master)

It happens even without VisualEditor and VEForAll.

Do either of you know with which versions this still worked?

malberts · 2022-03-26T19:03:04Z

Looks like this has not worked for a long time. I went as far back as the following:
Mediawiki 1.35.5
Chameleon 3.1.0 (24 Sep 2020)
PageForms 5.0.1 (22 Dec 2020)

stefahn · 2022-04-08T21:09:09Z

Do either of you know with which versions this still worked?

I think with MediaWiki 1.34 and Chameleon 3 it still worked.

stefahn · 2022-11-02T13:33:37Z

Hm, this bug causes trouble in our team since edited text sometimes gets lost when one clicks on "Show changes".

Any update on this? Thanks a lot!

stefahn · 2023-01-06T14:43:34Z

The problem also occurs when I click on "Show preview".

Do you think it's a Chameleon issue or a PageForms issue?

ckapop · 2023-10-04T18:11:02Z

Any news on this?

ckapop · 2023-10-08T23:38:32Z

I think I might have found the issue that was causing this error. Since the code change it seems to be working as expected.

I am using Chameleon 4.1.0
Within the protected function buildContentBody() in MainContent.php make the following change:

// Comment out this line.
// $this->indent() . $this->getSkinTemplate()->get( 'bodytext' ) .
// Replace with this line.
$this->indent() . $this->getSkin()->getOutput()->mBodytext .

If you are using a newer version and still have the same issue it looks like things have changed a bit with MainContent.php.
Within the protected function buildContentBody() in ContentBody.php maybe make the same change as above.

I will keep testing but so far it seems to be working for me.

WouterRademaker · 2023-10-11T08:48:38Z

Ckapop's fix fixes the problem on Chameleon 4.2.1 too, but it introduces another problem. The fix breaks the Maps extension, maps remain greyed out, busy loading.

Maps 10.0.0

ckapop · 2023-10-11T16:10:11Z

It also breaks editing with Visual Editor, same busy loading type issue. Still investigating this.

ckapop · 2023-10-13T17:50:31Z

@WouterRademaker, I think I have another workaround if you would like to try it out. It seems the template created by the Page Form previews isn't making it's way down to the Chameleon components. Remove any of the previous changes and start from scratch before making these edits. Let me know if you see any weird behavior. Maps and the VE are rendering for me with this work around.

src/ChameleonTemplate.php

	public function execute() {
		// output the head element
		// The headelement defines the <body> tag itself, it shouldn't be included in the html text
		// To add attributes or classes to the body tag use OutputPageBodyAttributes hook
		$this->html( 'headelement' );
		echo $this->getSkin()->getComponentFactory()->getRootComponent()->getHtml($this); // Added $this
		$this->printTrail();
		echo "</body>\n</html>";
	}

src/Components/Structure.php

	public function getHtml($tpl = null) { // Added $tpl = null
		$ret = '';

		foreach ( $this->getSubcomponents() as $component ) {
			$ret .= $component->getHtml($tpl); // Added $tpl
		}

		return $ret;
	}

src/Components/Container.php

	public function getHtml($tpl = null) { // Added $tpl = null
		$attribs = [ 'class' => $this->getClassString() ];

		$id = $this->getAttribute( 'id' );
		if ( $id !== '' ) {
			$attribs['id'] = IdRegistry::getRegistry()->getId( $id );
		}

		$ret = $this->indent() . \Html::openElement( 'div', $attribs );
		$this->indent( 1 );

		$ret .= parent::getHtml($tpl); // Added $tpl

		$ret .= $this->indent( -1 ) . '</div>';

		return $ret;
	}

src/Components/MainContent.php

	public function getHtml($tpl = null) { // Added $tpl = null
                // Added if block to set template
		if ( !is_null( $tpl ) ) {
                	$this->setSkinTemplate($tpl);
                }
		$idRegistry = IdRegistry::getRegistry();

		$topAnchor = $idRegistry->element( 'a', [ 'id' => 'top' ] );
		$mwIndicators = $idRegistry->element( 'div', [ 'id' => 'mw-indicators',
			'class' => 'mw-indicators', ], $this->buildMwIndicators() );

		$mwBody =
			$topAnchor .
			$this->indent( 1 ) . $mwIndicators .

			$this->buildContentHeader() .
			$this->buildContentBody() .
			$this->buildCategoryLinks() .
			$this->indent( -1 );

		return $this->indent() . '<!-- start the content area -->' .
			$this->indent() . $idRegistry->element(
				'div',
				[ 'id' => 'content', 'class' => 'mw-body ' . $this->getClassString() ],
				$mwBody
			);
	}

src/Components/Component.php

    // Add this function
    public function setSkinTemplate($tpl) {
        $this->mSkinTemplate = $tpl;
    }

WouterRademaker · 2023-10-13T20:15:31Z

@ckapop I have tried out the changes, but the only thing I get is a blank page with an empty body. Are these 4 changes the only ones you made?

ckapop · 2023-10-13T21:15:11Z

@WouterRademaker Sorry, I did forget something. I added 5 above.

WouterRademaker · 2023-10-13T21:37:17Z

@ckapop, Still a blank page with an empty body.

ckapop · 2023-10-14T00:31:53Z

@WouterRademaker I get the blank screen with the empty body if I omit step 5. It is working for me with step 5. I recently added $tpl parameter to all the other classes extending Component. just to be safe and it's working. I put the changes here: https://github.com/ckapop/chameleon/tree/pageform-preview-test

WouterRademaker · 2023-10-14T09:23:56Z

@ckapop you used version 4.1.0 as basis, but I tried the changes on version 4.2.1, that didn't work.

I'm now testing your version 4.1.0.

ckapop · 2023-10-20T15:06:57Z

@WouterRademaker How did your 4.1.0 test go?

WouterRademaker · 2023-10-20T15:50:35Z

How did your 4.1.0 test go?

I have added this to "chameleon.css" to separate the preview from the edit form and box. This to avoid getting the edit form next to a long info box.
#pfForm { clear: both; border-top: 1px solid rgba(0,0,0,0.1); }
Other than that, I don't see any problems.

WouterRademaker · 2023-10-31T12:10:36Z

@ckapop It might be useful to see what changes are needed on ~~4.2.1~~ 4.3.0 / Master to solve this problem. So that the changes can be included in the next release.

ckapop · 2023-11-08T17:36:35Z

Agree. I will investigate this next week when we upgrade to the latest version.

WouterRademaker · 2023-11-27T11:48:22Z

I have tried to do the changes on 4.3.0: https://github.com/WouterRademaker/chameleon
It seems to work, @ckapop please test.

ckapop · 2023-12-14T19:58:55Z

@WouterRademaker there seems to be an issue causing createIncompleteSetupTaskNotification to get displayed twice. I am looking into it.

WouterRademaker · 2023-12-14T20:01:28Z

@ckapop and the PHPUnit tests needs updating.

ckapop · 2023-12-14T21:38:19Z

@WouterRademaker So the createIncompleteSetupTaskNotification duplication display is also happening in the default Vector skin so I think this is a PageForms issue.

WouterRademaker · 2024-07-31T15:59:43Z

The bug still with MediaWiki 1.39.8, Chameleon 4.4.0 and Page Forms 5.7.2

malberts added the bug label Mar 26, 2022

WouterRademaker mentioned this issue Dec 4, 2023

Show edit window and buttons below changes when using PageForms #406

Open

WouterRademaker mentioned this issue Aug 5, 2024

Show edit window and buttons below changes when using PageForms for chameleon version 4.4.x #436

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Show changes" doesn't show edit window and buttons below the changes #319

"Show changes" doesn't show edit window and buttons below the changes #319

stefahn commented Mar 15, 2022 •

edited

Loading

WouterRademaker commented Mar 15, 2022

malberts commented Mar 26, 2022

malberts commented Mar 26, 2022

stefahn commented Apr 8, 2022

stefahn commented Nov 2, 2022

stefahn commented Jan 6, 2023

ckapop commented Oct 4, 2023

ckapop commented Oct 8, 2023 •

edited

Loading

WouterRademaker commented Oct 11, 2023 •

edited

Loading

ckapop commented Oct 11, 2023 •

edited

Loading

ckapop commented Oct 13, 2023 •

edited

Loading

WouterRademaker commented Oct 13, 2023

ckapop commented Oct 13, 2023 •

edited

Loading

WouterRademaker commented Oct 13, 2023

ckapop commented Oct 14, 2023 •

edited

Loading

WouterRademaker commented Oct 14, 2023 •

edited

Loading

ckapop commented Oct 20, 2023

WouterRademaker commented Oct 20, 2023 •

edited

Loading

WouterRademaker commented Oct 31, 2023 •

edited

Loading

ckapop commented Nov 8, 2023

WouterRademaker commented Nov 27, 2023 •

edited

Loading

ckapop commented Dec 14, 2023

WouterRademaker commented Dec 14, 2023 •

edited

Loading

ckapop commented Dec 14, 2023 •

edited

Loading

WouterRademaker commented Jul 31, 2024

"Show changes" doesn't show edit window and buttons below the changes #319

"Show changes" doesn't show edit window and buttons below the changes #319

Comments

stefahn commented Mar 15, 2022 • edited Loading

WouterRademaker commented Mar 15, 2022

malberts commented Mar 26, 2022

malberts commented Mar 26, 2022

stefahn commented Apr 8, 2022

stefahn commented Nov 2, 2022

stefahn commented Jan 6, 2023

ckapop commented Oct 4, 2023

ckapop commented Oct 8, 2023 • edited Loading

WouterRademaker commented Oct 11, 2023 • edited Loading

ckapop commented Oct 11, 2023 • edited Loading

ckapop commented Oct 13, 2023 • edited Loading

WouterRademaker commented Oct 13, 2023

ckapop commented Oct 13, 2023 • edited Loading

WouterRademaker commented Oct 13, 2023

ckapop commented Oct 14, 2023 • edited Loading

WouterRademaker commented Oct 14, 2023 • edited Loading

ckapop commented Oct 20, 2023

WouterRademaker commented Oct 20, 2023 • edited Loading

WouterRademaker commented Oct 31, 2023 • edited Loading

ckapop commented Nov 8, 2023

WouterRademaker commented Nov 27, 2023 • edited Loading

ckapop commented Dec 14, 2023

WouterRademaker commented Dec 14, 2023 • edited Loading

ckapop commented Dec 14, 2023 • edited Loading

WouterRademaker commented Jul 31, 2024

stefahn commented Mar 15, 2022 •

edited

Loading

ckapop commented Oct 8, 2023 •

edited

Loading

WouterRademaker commented Oct 11, 2023 •

edited

Loading

ckapop commented Oct 11, 2023 •

edited

Loading

ckapop commented Oct 13, 2023 •

edited

Loading

ckapop commented Oct 13, 2023 •

edited

Loading

ckapop commented Oct 14, 2023 •

edited

Loading

WouterRademaker commented Oct 14, 2023 •

edited

Loading

WouterRademaker commented Oct 20, 2023 •

edited

Loading

WouterRademaker commented Oct 31, 2023 •

edited

Loading

WouterRademaker commented Nov 27, 2023 •

edited

Loading

WouterRademaker commented Dec 14, 2023 •

edited

Loading

ckapop commented Dec 14, 2023 •

edited

Loading