Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StickyTOC hide/show does not work #408

Closed
krabina opened this issue Dec 7, 2023 · 2 comments · Fixed by #410
Closed

StickyTOC hide/show does not work #408

krabina opened this issue Dec 7, 2023 · 2 comments · Fixed by #410
Assignees
@malberts

Comments

@krabina
Copy link
Contributor

krabina commented Dec 7, 2023

Ever since the new StickyTOC component was implemented (thank you, btw!), the hide/show did never work for me. Tested in FF and Chrome. No errors in the console. In my wiki set to German the labels are "Verbergen", "Anzeigen".
Using MW 1.39/Chameleon 4.3.0
Did also not work om MW 1.35.
@D-Groenewegen
Copy link
Contributor

The request for that feature seems to be #390, which is still open. To go by @malbert's comment in #396, I suspect it wasn't ready for use just yet.

@malberts
Copy link
Contributor

I believe this was fixed in a bigger open PR: #405

We can extract just the fix for the hide/show in a smaller PR.

@malberts malberts self-assigned this Dec 23, 2023
@malberts malberts mentioned this issue Dec 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malberts malberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ToC hide/show button ProfessionalWiki/chameleon
3 participants
@malberts @krabina @D-Groenewegen