Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing suffix option when creating a protection group snapshot #73

Open
BenoitGodin1 opened this issue Oct 20, 2023 · 1 comment
Open
Labels
invalid This doesn't seem right

Comments

@BenoitGodin1
Copy link

When creating a protection group snapshot with post_protection_group_snapshots, there's no option to provide a suffix for the snapshot name:

def post_protection_group_snapshots(
self,
sources=None, # type: List[models.ReferenceType]
authorization=None, # type: str
x_request_id=None, # type: str
apply_retention=None, # type: bool
source_names=None, # type: List[str]
protection_group_snapshot=None, # type: models.ProtectionGroupSnapshotPost
async_req=False, # type: bool
_return_http_data_only=False, # type: bool
_preload_content=True, # type: bool
_request_timeout=None, # type: Optional[int]
):

But the classes ProtectionGroupSnapshot and ProtectionGroupSnapshotPost have an attribute suffix:
class pypureclient.flasharray.ProtectionGroupSnapshot(name=None, created=None, destroyed=None, pod=None, source=None, space=None, suffix=None, time_remaining=None, eradication_config=None, id=None)

class pypureclient.flasharray.ProtectionGroupSnapshotPost(id=None, name=None, created=None, destroyed=None, pod=None, source=None, space=None, suffix=None, time_remaining=None, eradication_config=None)

and for each, init accepts a suffix parameter:
suffix (str) – The name suffix appended to the protection group name to make up the full protection group snapshot name in the form PGROUP.SUFFIX

Is it possible to update post_protection_group_snapshots to include the suffix option?

@sdodsley
Copy link
Contributor

sdodsley commented Dec 8, 2023

@BenoitGodin1 Not sure what you are having a problem with. You can specify the suffix name for a PG snapshot very easily bys using either of these two methods:

suffix = flasharray.ProtectionGroupSnapshot(suffix=<suffix>)
array.post_protection_group_snapshots(
            source_names=[<pgroup_name>],
            protection_group_snapshot=suffix)

or

suffix = flasharray.ProtectionGroupSnapshotPost(suffix=<suffix>)
array.post_protection_group_snapshots(
            source_names=[<pgroup_name>],
            protection_group_snapshot=suffix)

@sdodsley sdodsley added the invalid This doesn't seem right label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants